Skip to content

Allow using Webcomponents.js 1.x #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wdkuc wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Allow using Webcomponents.js 1.x #86

wdkuc wants to merge 5 commits into from

Conversation

@wdkuc
Copy link

@wdkuc wdkuc commented Nov 28, 2017 •
edited by manolo
Loading

This change is Reviewable
@wdkuc wdkuc changed the title Base support for Polymer 2.x and Webcomponents.js 1.x Allow using Webcomponents.js 1.x Nov 28, 2017
@manolo
Copy link
Owner

manolo commented Dec 11, 2017

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

lib/com/vaadin/polymer/Polymer.java, line 51 at r1 (raw file):

 */ @JsProperty(namespace = JsPackage.GLOBAL) public static native void setWebcomponentsJsLocation(String s);

Any reason for publishing this variable in window scope? I think just a static string in this class might be enough

Comments from Reviewable
@manolo
Copy link
Owner

manolo commented Dec 11, 2017

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

lib/com/vaadin/polymer/Polymer.java, line 67 at r1 (raw file):

 } if(getWebcomponentsJsLocation() == null) { setWebcomponentsJsLocation("webcomponentsjs/webcomponents-lite.min.js");

shouldn't it be webcomponents-lite.js instead ?

Comments from Reviewable
@vegegoku
Copy link
Collaborator

vegegoku commented Dec 11, 2017

in my other PR i renamed the file, since the webcomponents-lite.min.js is not there anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@wdkuc @manolo @vegegoku