update Set values() and valuesLegacy() to return items values instead… #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| Thanks for the PR! |
loiane added a commit that referenced this pull request Jan 17, 2016
update Set values() and valuesLegacy() to return items values instead…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
… of items keys
Hi Loiane. I'm enjoying your book! I'd like to suggest a modification to your Set implementation in chapter 6. Your
values()method is really returning the keys to theitemsobject. One consequence of this is that String values are being returned in the array, since JS coerced the numerical values to Strings in order to use them as keys in theitemsobject. It might be better to return the actual numeric values? Hence my PR.