General improvements #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Update dependencies. - Test with libvips 8.6.3 on Travis. - Use pyvips for the auto-generated docs/enums (fixes libvips#56). - Regenerate docs/enums. - If statement can be merged with parent one.
| This is brilliant Kleis! The dependency on an old version of ruby-vips was very annoying, but I was too lazy to fix it. I had one comment on the enum introspection, the rest looks great. |
kleisauke commented Jun 10, 2018
| # otherwise we're missing some enums | ||
| vips_lib.vips_token_get_type() | ||
| vips_lib.vips_saveable_get_type() | ||
| vips_lib.vips_image_type_get_type() |
There was a problem hiding this comment.
I'm not quite sure why I should call these functions, but without these lines those enums aren't generated.
There was a problem hiding this comment.
Yes, most enums need to be explicitly initialized.
| Great! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Depends on: https://github.com/jcupitt/pyvips/pull/47.
generate_phpdoc.rbaway from ruby-vips 1.x #56).