Enable phpcs for Travis + more #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Update phpunit. - Update sigmoidal contrast example. - Fix regression from libvips#49. - Rename the test files and apply the correct namespace.
kleisauke commented Aug 25, 2017
tests/ShortcutTest.php Outdated
| } | ||
| $real = self::mapNumeric($this->pixel, function ($value) { | ||
| // FIXME: Left and right operands are identical | ||
| return $value > $value ? 255 : 0; |
There was a problem hiding this comment.
Should we just return 0 here?
There was a problem hiding this comment.
I agree, perhaps with a comment saying something like "(x > x) is always false".
| Lots of nice improvements Kleis! |
| I think we could enable phpcs warnings if we exclude |
+ bump Travis libvips to 8.5.8
| Great work! |
| FYI: Also bumped the Travis libvips to 8.5.8. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
bandjoin/bandrankaImageclass didn't work).