Replace gRPC Status#equals() with Status#isOk(). Status#equals() uses reference equality. Status#isOk() or comparing Status#getCode() is preferred. (firebase#2436)

Author: groakley

firebase-firestore/src/main/java/com/google/firebase/firestore/remote/AbstractStream.java

@@ -273,7 +273,7 @@ public void start() {
  private void close(State finalState, Status status) {
  hardAssert(isStarted(), "Only started streams should be closed.");
  hardAssert(
- finalState == State.Error || status.equals(Status.OK),
+ finalState == State.Error || status.isOk(),
  "Can't provide an error when not in an error state.");
  workerQueue.verifyIsCurrentThread();
 

firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteStore.java

@@ -468,7 +468,7 @@ private void handleWatchChange(SnapshotVersion snapshotVersion, WatchChange watc
  }
 
  private void handleWatchStreamClose(Status status) {
- if (Status.OK.equals(status)) {
+ if (status.isOk()) {
  // Graceful stop (due to stop() or idle timeout). Make sure that's desirable.
  hardAssert(
  !shouldStartWatchStream(), "Watch stream was stopped gracefully while still needed.");
@@ -655,7 +655,7 @@ private void handleWriteStreamMutationResults(
  }
 
  private void handleWriteStreamClose(Status status) {
- if (Status.OK.equals(status)) {
+ if (status.isOk()) {
  // Graceful stop (due to stop() or idle timeout). Make sure that's desirable.
  hardAssert(
  !shouldStartWriteStream(), "Write stream was stopped gracefully while still needed.");