Skip to content

build(deps): update dependabot config, bump sigs.k8s.io/controller-runtime from 0.22.3 to 0.22.4 in /conformance and /tests #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mikemorris wants to merge 3 commits into
base: dependabot/go_modules/conformance/sigs.k8s.io/controller-runtime-0.22.4
Choose a base branch
from
Open

build(deps): update dependabot config, bump sigs.k8s.io/controller-runtime from 0.22.3 to 0.22.4 in /conformance and /tests #4356

mikemorris wants to merge 3 commits into from
+5 −3

Conversation

@mikemorris
Copy link
Contributor

@mikemorris mikemorris commented Dec 15, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
#4289 has failing git diff because it only bumps the controller-runtime dep in /conformance and not tests
@rikatz it looks like the Dependabot config in

gateway-api/.github/dependabot.yml

Lines 7 to 8 in c448aed

- "/conformance"
- "/tests"
should be bumping the dep in both directories, so I'm not sure why it was missed but go work sync does expect it.

Which issue(s) this PR fixes:

Fixes #4289

Does this PR introduce a user-facing change?:
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2025
@mikemorris
Copy link
Contributor Author

mikemorris commented Dec 15, 2025

/release-note-none
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 15, 2025
@rikatz
Copy link
Member

rikatz commented Dec 15, 2025

yeah, it should be bumping on both directories. This is some dependabot weirdness, it has some issues with go workspaces (from last time I saw it). I will take a look later if there's something that it should be doing and it is not

/lgtm
/approve

Thanks!
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mikemorris, rikatz
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@rikatz
Copy link
Member

rikatz commented Dec 15, 2025

ah wait, should the bump also contain "sigs.k8s.io" as a pattern? like

gateway-api/.github/dependabot.yml

Line 15 in c448aed

- "k8s.io/*"

@mikemorris
Copy link
Contributor Author

mikemorris commented Dec 15, 2025

ah wait, should the bump also contain "sigs.k8s.io" as a pattern?

Ah, that's why it worked as expected for #4353!
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2025
@mikemorris
Copy link
Contributor Author

mikemorris commented Dec 15, 2025 •
edited
Loading

Added a commit to include sigs.k8s.io in dependabot groups, I think the echo-basic config will always just no-op though, as https://github.com/kubernetes-sigs/gateway-api/tree/main/conformance/echo-basic doesn't appear to have any k8s.io deps?
@mikemorris mikemorris changed the title build(deps): bump sigs.k8s.io/controller-runtime from 0.22.3 to 0.22.4 in /conformance and /tests build(deps): bump sigs.k8s.io/controller-runtime from 0.22.3 to 0.22.4 in /conformance and /tests, update dependabot config Dec 15, 2025
@mikemorris mikemorris changed the title build(deps): bump sigs.k8s.io/controller-runtime from 0.22.3 to 0.22.4 in /conformance and /tests, update dependabot config build(deps): update dependabot config, bump sigs.k8s.io/controller-runtime from 0.22.3 to 0.22.4 in /conformance and /tests Dec 15, 2025
@rikatz
Copy link
Member

rikatz commented Dec 15, 2025

/lgtm
Thanks!
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

3 participants

@mikemorris @rikatz @k8s-ci-robot