feat: add shadow dom support, fixes #321 #479
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
add page to demo shadow dom support, change the getElementByID call from the document to a more angular friendly way to support shadow dom encapsulation
Codecov Report
@@ Coverage Diff @@ ## master #479 +/- ## ========================================== + Coverage 20.66% 20.91% +0.24% ========================================== Files 8 8 Lines 479 483 +4 Branches 103 103 ========================================== + Hits 99 101 +2 - Misses 377 379 +2 Partials 3 3
Continue to review full report at Codecov.
|
| The same issue is happening to me. Does anyone have a solution? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using angular-editor under a shadow dom encapsulated component, it was throwing errors as it tried to find some elements by their id's using the global document api:
This pull request tries to solve it by changing the way we access those elements using Angular's ElementRef instead of document.
It also adds a new page on the angular-editor-app project to showcase the use of angular-editor under a shadow dom encapsulated component.
Test are passing:
