Skip to content

Fix README.md #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2021
Merged

Fix README.md #49

merged 1 commit into from
Jul 9, 2021

Conversation

takeokunn
Copy link
Contributor

In SimpleImageSliderProps type definitions, showNavs and showBullets are required, but README.md says "Optional".
https://github.com/kimcoder/react-simple-image-slider/blob/master/src/ImageSlider.tsx#L12-L13

So I fixed it.

Thanks!
@kimcoder
Copy link
Owner

kimcoder commented Jul 9, 2021

Thanks: )
@kimcoder kimcoder merged commit 76bb00a into kimcoder:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@takeokunn @kimcoder