Add a white background on the Rust icon (README) #215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kelvins reviewed Sep 28, 2023
There was a problem hiding this comment.
Hi @leandronsp, I'm not sure if this works in Github markdown files, at least it hasn't been rendered here. I also found this Stackoverflow question related to this topic and looks like CSS can only be used inside foreignObject.
We could have our custom SVG logos that fit the color scheme, that would be amazing, but it's kind of tricky to create.
| I got it, changing directly the SVG would be a better option. What do you prefer? Should we close this PR linking to a new issue for whoever could work on SVG's? |
| Yes, it makes sense, feel free to create the issue 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For those utilizing dark mode, the Rust logo on the table in the README file is not easily visible. To enhance visibility, I have added a white background to the logo using inline CSS.