Skip to content

Conversation

thomas-martin-uf
Copy link
Contributor

Adding a recursive towers of hanoi solution for c++. Edited the readme link so that the correct svg icon was used and confirmed the link works to the desired solution.

Copy link
Collaborator

@ricardocarva ricardocarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution, @thomas-martin-uf. I left a comment about the file name. It’s easier if the file name is in English if we’re gonna translate the repo.

Copy link
Collaborator

@ricardocarva ricardocarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find how to suggest the name change for the file itself.

@ricardocarva
Copy link
Collaborator

@kelvins, I approved here, but I think it doesn’t go through unless you approve it?

@kelvins
Copy link
Owner

kelvins commented Sep 20, 2023

Hey folks, thanks for contributing 🚀

Could you please double check the sequence of movements?

With 3 discs it should print something like this:

move disc from A to C move disc from A to B move disc from C to B move disc from A to C move disc from B to A move disc from B to C move disc from A to C 
@thomas-martin-uf
Copy link
Contributor Author

Print order was incorrect and somehow I just overlooked because the move total was right. My fault. I have recommitted and believe it's correct now.

@ricardocarva
Copy link
Collaborator

ricardocarva commented Sep 20, 2023

Sorry, I thats right. The number of disks was 4 when we actually had 3, and the order they were printed was off. Seems correct now. The output matches.

@kelvins kelvins merged commit 58a8468 into kelvins:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants