further changes #100
Merged
further changes #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jonathan-caryl commented Mar 15, 2017
| compile "com.github.akarnokd:rxjava2-extensions:0.16.0" | ||
| compile 'com.jakewharton.rxrelay2:rxrelay:2.0.0' | ||
| compile 'com.jakewharton.rxbinding:rxbinding:0.2.0' | ||
| compile 'com.jakewharton.rxbinding2:rxbinding:2.0.0' |
Contributor Author
There was a problem hiding this comment.
Now RxJava2 friendly!
jonathan-caryl commented Mar 15, 2017
| import com.morihacky.android.rxjava.rxbus.RxBus; | ||
| | ||
| public class MainActivity extends FragmentActivity { | ||
| public class MainActivity extends AppCompatActivity { |
Contributor Author
There was a problem hiding this comment.
The app was missing the ActionBar because we weren't using AppCompatActivity
Contributor Author
| @kaushikgopal hope this PR's good too. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some more SDK updates etc.