add failing test case for prop-types Validating external propTypes #762
+30 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2016
ljharb force-pushed the master branch 6 times, most recently from 59af733 to 865ed16 Compare ljharb force-pushed the master branch 4 times, most recently from 069314a to 181c68f Compare ljharb force-pushed the master branch 2 times, most recently from 380e32c to 51d342b Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@yannickcr this adds a failing test case for the following issue
#322
The first
Foocase passes, and the secondBarcase fails.I'd be happy to help figure out a way to support this, I'm just not entirely sure how the linting processes works.
I also have a few other test cases in mind, but I figured I'd start with the simplest case first and see how that goes.