Fixes #4995 - Modal Dialog's overlay dissapears in IE when content is tall #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…e document and take the higher value. Fixes #4995 - Modal Dialog's overlay dissapears in IE when content is tall
… - Modal Dialog's overlay dissapears in IE when content is tall
Author
| I reviewed and edited it with Scott advices |
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi jQuery Core Commiters,
I made my first bug fix for the jQuery Framework (Ticket #4995). This bug dissapeared in all browser, not only IE like described.
The Problem was, that the modal overlay was displayed before the dialog with the height of the document. When the dialog was higher than the document height, before the dialog has been shown, the dialog increased the height of the document. And so the height of the modal overlay was too short.
I've added a if statement, which checks whether the dialog is higher than the document and take the higher value.
I've tested it in Google Chrome 9, IE 8, FF 3.6, FF 4.0 Beta, Safari 5.0 and Opera 11.0
Regards Jo
PS: please let me know, if you contented with my work