Skip to content

Dialog Redesign #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 24, 2012
Merged

Dialog Redesign #787

merged 6 commits into from
Oct 24, 2012

Conversation

@jzaefferer
Copy link
Member

@jzaefferer jzaefferer commented Oct 22, 2012

For now just for code review.

Just improved the moveToTop method to get rid of the event handling issues, see last commit for details.

/cc @neagle @artzstudio
scottgonzalez
scottgonzalez reviewed Oct 22, 2012
View reviewed changes
ui/jquery.ui.dialog.js Outdated
Copy link
Member

@scottgonzalez scottgonzalez Oct 22, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace
@jzaefferer
Copy link
Member Author

jzaefferer commented Oct 22, 2012

After some more cleanup we squashed all the changes so far into a single commit.
@jzaefferer
Copy link
Member Author

jzaefferer commented Oct 22, 2012

http://bugs.jqueryui.com/ticket/4671 - fixed
@scottgonzalez
Copy link
Member

scottgonzalez commented Oct 22, 2012

http://bugs.jqueryui.com/ticket/4975 - wontfix
@scottgonzalez
Copy link
Member

scottgonzalez commented Oct 22, 2012

http://bugs.jqueryui.com/ticket/5388 - fixed
@scottgonzalez
Copy link
Member

scottgonzalez commented Oct 22, 2012

http://bugs.jqueryui.com/ticket/5762 - fixed
@jzaefferer
Copy link
Member Author

jzaefferer commented Oct 22, 2012

http://bugs.jqueryui.com/ticket/5968 - works fine in master: https://gist.github.com/1107b76f5c0b2b71250a
Need to track down where this got fixed.
@scottgonzalez
Copy link
Member

scottgonzalez commented Oct 22, 2012

http://bugs.jqueryui.com/ticket/3534 - fixed
@scottgonzalez
Copy link
Member

scottgonzalez commented Oct 22, 2012

http://bugs.jqueryui.com/ticket/4727 - needs review
@jzaefferer
Copy link
Member Author

jzaefferer commented Oct 22, 2012

based on z-index handling, which is now gone:
http://bugs.jqueryui.com/ticket/5466 - fixed
http://bugs.jqueryui.com/ticket/6267 - fixed
http://bugs.jqueryui.com/ticket/7051 - fixed (slider handle has z-index of 2, that didn't go well with the old z-index stuff)
http://bugs.jqueryui.com/ticket/7107 - fixed
http://bugs.jqueryui.com/ticket/7120 - fixed
http://bugs.jqueryui.com/ticket/5649 - fixed, probably (nothing to test with)
@scottgonzalez
Copy link
Member

scottgonzalez commented Oct 22, 2012

http://bugs.jqueryui.com/ticket/8583 - fixed
http://bugs.jqueryui.com/ticket/8172 - fixed
@jzaefferer
Copy link
Member Author

jzaefferer commented Oct 22, 2012

http://bugs.jqueryui.com/ticket/7960 - still a problem, due to high z-index on resziable handle
@jzaefferer
Copy link
Member Author

jzaefferer commented Oct 22, 2012

http://bugs.jqueryui.com/ticket/4995 - pretty sure this is fixed by the new overlay code
http://bugs.jqueryui.com/ticket/4892 - looks fixed, sure really sure
http://bugs.jqueryui.com/ticket/4421 - looks fixed (focus is retained), though I'm unable to get anything other then the default animated show (width/height/opacity), only setting the duration has an effect; very broken when using { show: "clip" }, the dialog ends up under the overlay
@jzaefferer
Copy link
Member Author

jzaefferer commented Oct 23, 2012

#313 - close
#324 - close
#510 - close
#546 - close
#749 - close
#779 - close
@scottgonzalez scottgonzalez mentioned this pull request Oct 24, 2012
Closed
Nate Eagle and others added 6 commits October 24, 2012 16:56
@jzaefferer
Dialog: Awesome new stacking and overlay implementation. Fixes the fo…
3829a37 
…llowing tickets: Fixes #3534 - Dialog: Modal dialog disables all input elements on page. Fixes #4671 - Dialog: Modal Dialog disables vertical scroll bar in Chrome & Safari. Fixes #4995 - Dialog: Modal Dialog's overlay dissapears in IE when content is tall. Fixes #5388 - Dialog: Don't change z-index when already at the top. Fixes #5466 - Dialog: "modal" Dialog Incorrectly Cancels Input Events. Fixes #5762 - Dialog: Get rid of z-index workaround, document it instead. Fixes #6267 - Dialog: checkboxes that inherit a z-index < jqueryui.dialog z-index don't work. Fixes #7051 - Dialog: modal prevents tab key from moving focus off slider handle. Fixes #7107 - Dialog: Modal dialog event loss with high zindex child elements (FF 3.6). Fixes #7120 - Dialog: Modal operation interrupts drag drop marker functionality on gmaps. Fixes #8172 - Dialog: Change event cancelled when opening modal dialog from another modal dialog. Fixes #8583 - Dialog: Mouse event wrongly stopped. Fixes #8722 - Dialog: Remove stack option. Fixes #8729 - Dialog: Remove zIndex option.
@jzaefferer
Dialog: Prevent dialog form losing focus (or move it back in IE <= 8).
2a2a2c0
@jzaefferer
Dialog: Save the active element that opened the dialog and restore fo…
14691ae 
…cus to that. Fixes #8730 - Dialog: Restore focus to opener.
@DavidSouther @jzaefferer
Dialog: Prevent tabbing off any dialog. Fixes #3768 - Dialog: contain…
3a09a4a 
… focus within dialog.
@jzaefferer
Dialog: Keep focus inside dialog, even when dialog itself has focus.
513b6da
@jzaefferer
Dialog: Use _show and _hide consistently. Fixes #4892 - Dialog: zInde…
d07074d 
…x error with animated modal dialog.
@jzaefferer jzaefferer merged commit d07074d into master Oct 24, 2012
@jzaefferer
Copy link
Member Author

jzaefferer commented Oct 24, 2012

Landed in master. Thanks @neagle for kicking this off last week! You just closed 14 tickets as fixed!
@neagle
Copy link

neagle commented Oct 25, 2012

Great work, guys!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants

@jzaefferer @scottgonzalez @neagle @DavidSouther @usmonster