Accordion: Rename icon.headerSelected to icon.activeHeader #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| This needs to be backward compatible for the 1.9 release. |
Contributor Author
| Made the change to make this backwards compatible. Moved the compatibility code to where you moved the height option merge. |
…n extension. Moved normalization of icon options into _createIcons function so it will pick up changes when using $.accordion("option", "icons", {}). Contributor Author
| Made some changes that Scott and I discussed. Namely, moved the compatibility to it's own extension (instead of with the height option merge code). Also, changed it to use _createIcons to pick up changes after accordion creation. |
Member
| Thanks, landed in b6ed932. |
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Renamed based on forum post