Selectmenu: ARIA tweaks for keyboard events and closed menu operation #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ui/jquery.ui.selectmenu.js Outdated
Member
There was a problem hiding this comment.
Use single var, see also output of running grunt
Member
There was a problem hiding this comment.
Though in this case, just inline the variable, as its used just once.
Contributor Author
| New commit to address style issues. |
Member
| Thanks, landed. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The combobox (the a.ui-button element) is now set to refer to the same label as the base select using ARIA labelledby.
Set the combobox to update its aria-activedependent attribute from the focus callback of the internal menu instance. Does the aria-activedependent attribute need to be cleared when the menu instance is closed?
The Space key will now active/deactivate the menu.