Remove some problematic EditorConfig restrictions #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| We should fix the i18n files, but changing the requirements for externals makes sense. |
Contributor Author
| I updated the pull request to remove the Should I update #743 to fix What do you want to do about the trailing whitespace (which I have not made a pull request to fix yet)? |
Member
| Updates for i18n files and trailiing whitespace are welcome! |
Contributor Author
| I updated the commit message in this pull request to reflect the new single extra |
Member
| Thanks, landed in e629d9a |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Your EditorConfig file states that all JS files should insert final newlines and use LF line endings. This style is used consistently throughout the jquery-ui codebase (once pull request #743 is fixed) except for in the
external/and/i18n/directories. There are files with no final newline and files with CRLF line endings in these directories.There is also trailing whitespace in some of your files which contradicts your EditorConfig file. Would you prefer to trim the trailing whitespace in these files or modify your EditorConfig file to not force whitespace trimming.
Additionally your EditorConfig file states that trailing whitespace should be trimmed. Every JavaScript file in your repository appears to have trailing whitespace.
Files with line ending and final newline problems:
Files with trailing whitespace: