bug fix for jquery ui resizable grid and ghost functionality at the same time #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…g to grid functionality still works. Previously if you try to use both, the ghost will adhere to the grid, but once you let go of the click it will resize the element to the last place your mouse is at and disregards the grid. This code in _mouseStop fixes this by doing a check to see if both properties exist. If they do then it runs through the grid logic before resizing. This code can definitely be optimized and im open to suggestions. I just ran into this issue when trying to use both together and this was the fix that worked for me.
Contributor
| This patch is an incomplete fix which is a partial fix to the problem. |
Member
| Thanks for your patch, but the ghost and grid options are both planned for removal as part of our current API redesign. |
Contributor
| On the lines of API redesign what are the plans for testing of UI objects? Will something like https://github.com/windmill/windmill be used to help test object interaction? |
Member
| We use QUnit and TestSwarm for testing. |
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a fix so that when using resizable grid and resizable ghost the snapping to grid functionality still works. Previously if you try to use both, the ghost will adhere to the grid, but once you let go of the click it will resize the element to the last place your mouse is at and disregards the grid. This code in _mouseStop fixes this by doing a check to see if both properties exist. If they do then it runs through the grid logic before resizing. This code can definitely be optimized and im open to suggestions. I just ran into this issue when trying to use both together and this was the fix that worked for me.