Skip to content

Conversation

@kborchers
Copy link
Member

Resizable: Check if resizable is in a scrollable container and if so, add the scroll offsets when repositioning. Fixed #3815 - Resizable absolutely positioned element inside scrollable element is repositioned when resized

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you also be checking for scrollWidth vs width?

Also, I don't think this would solve the issue in a nested scrollable right?

Take a look at $.ui.hasScroll as well

@gnarf
Copy link
Member

gnarf commented May 24, 2011

Did you manage to make any nice reduced test cases for this one? I would like to see a fiddle of the bug to know exactly what I'm reviewing.

@kborchers
Copy link
Member Author

Here is the same fiddle I just added to the ticket. http://jsfiddle.net/x83Pa/4/ I will try cleaning this up tomorrow when I am at my other machine with my tests.

@kborchers
Copy link
Member Author

@gnarf Did you get a chance to look at that fiddle and review this? I did notice that this pull conflicts with my latest pull but once one is approved it should be pretty easy to modify the other to have them work together.

@gnarf
Copy link
Member

gnarf commented May 27, 2011

@scottgonzalez - 3 commits here, but this seems to solve the issue... You suggested using a scroll event on another pull recently, I'm not sure if that would be a good choice for this bug too or not... Opinion?

@scottgonzalez
Copy link
Member

@gnarf37 there are two separate issues: 1) if you scroll the parent and then try to resize, the resizable element will jump up 2) if you scroll while resizing, the resizable doesn't adjust for the distance that you've scrolled.

#1 is the more important bug and the one that's being addressed here. Solving #1 doesn't need to listen to scroll events as the problem is isolated to the start of the interaction. Solving #2 probably would need to listsen to scroll events, but I don't think we should worry about that until the rewrite.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we can't use .parentsUntil() in 1.8.x since it wasn't added until 1.4.

@kborchers
Copy link
Member Author

Changed .parentsUntil("body") to parents(":not('body, html')") and combined into a single commit

… add the scroll offsets when repositioning. Fixed #3815 - Resizable absolutely positioned element inside scrollable element is repositioned when resized
@kborchers
Copy link
Member Author

Removed unnecessary quotes in the not selector

@kborchers
Copy link
Member Author

Since interactions are being rewritten, I am closing this pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants