Skip to content

Conversation

@fnagel
Copy link
Member

@fnagel fnagel commented Jul 8, 2022

@fnagel fnagel self-assigned this Jul 8, 2022
@fnagel fnagel added this to the 1.13.2 milestone Jul 8, 2022
@fnagel fnagel marked this pull request as draft July 8, 2022 01:11
@fnagel fnagel force-pushed the remove-special-chars-from-localization branch from 931c141 to 5cc4b3f Compare July 9, 2022 00:25
@fnagel fnagel marked this pull request as ready for review July 9, 2022 00:29
@fnagel fnagel requested a review from mgol July 9, 2022 00:29
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one question: do we want to merge #2050 separately before this one to preserve the original author of that change?

@fnagel
Copy link
Member Author

fnagel commented Jul 13, 2022

@mgol We can do this but another (maybe more easier option) would be to just go ahead and merge all three commits of this PR without squashing them to one. I would prefer the latter one.

@mgol
Copy link
Member

mgol commented Jul 13, 2022

@fnagel ok, that works for me. The only caveat is you should amend the last commit manually to add Closes gh-2100 to the commit message as using Rebase and merge doesn’t let you modify the message when merging and we’d lose the link to this PR.

@mgol mgol force-pushed the remove-special-chars-from-localization branch from 5cc4b3f to a469baa Compare July 14, 2022 16:26
@mgol mgol merged commit 395aa7d into jquery:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment