Allow autocomplete traversal by holding arrow keys #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ding down arrow keys in Firefox does not traverse list Use keypress event for listening for arrow keys because Firefox and Opera do not repeat keydown events for these keys.
Member
| Thanks! Could you also take a stab at http://bugs.jqueryui.com/ticket/6666 ? |
Contributor Author
| @jzaefferer will do. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I'm submitting this for discussion.
This commit migrates up and down arrow listeners to the
keypressevent binding. Firefox and Opera do not repeatkeydownevents for these keys so holding down the arrow key traversed through a long list for Chrome but not Firefox and Opera.This should fix the ticket I submitted on this behavior: #7269.
If representing key presses consistently across multiple browsers is important, the current
keydownevents should probably be abstracted into a separate binding. The keydown or keypress for each key could then trigger this separate binding as needed.