Skip to content

Fix max height of the selectmenu and collision default #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix max height of the selectmenu and collision default #1428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ui/selectmenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ return $.widget( "ui.selectmenu", {
position: {
my: "left top",
at: "left bottom",
collision: "none"
collision: "flip"
},
width: null,

Expand Down Expand Up @@ -617,6 +617,15 @@ return $.widget( "ui.selectmenu", {
// so we add 1px to avoid the wrapping
this.menu.width( "" ).outerWidth() + 1
) );

// Reset the height of the menu and calculate the max height
this.menu.css( "height", "auto" );
var menuHeight = this.menu.height();
var maxMenuHeight = Math.round( $( window ).height() / 3 );

if ( maxMenuHeight < menuHeight ) {
this.menu.height( maxMenuHeight );
}
},

_getCreateOptions: function() {
Expand Down