Skip to content

Conversation

@thg2k
Copy link
Contributor

@thg2k thg2k commented Dec 30, 2014

I know this is never going to be accepted, but I'm still submitting the changes we are running with the local integration because your spinner was seriously broken. Below a summary of changes, I'd like to hear your comments and obviously see my patch integrated.

detailed changes:

  • _getCreateOptions() now initializes 'disabled', moved before _create()
  • in _create(), _draw must be invoked before this._value()
  • added in _events() handlers for hover and focus states
  • added widget() overridden function, should work as expected if i understood correctly the original idea of widget() method
  • fixed disabled handling, correctly disables the widget
detailed changes: - _getCreateOptions() now initializes 'disabled', moved before _create() - in _create(), _draw must be invoked before this._value() - added in _events() handlers for hover and focus states - added widget() overridden function, should work as expected if i understood correctly the original idea of widget() method - fixed disabled handling, correctly disables the widget
@thg2k
Copy link
Contributor Author

thg2k commented Dec 30, 2014

before you say it:

  1. No, i'm not going to submit separate patches
  2. No, i'm not going to submit test cases.
@scottgonzalez
Copy link
Member

before you say it:

  1. No, i'm not going to submit separate patches
  2. No, i'm not going to submit test cases.

Unfortunately, then our response is:

No, we will not accept it.

@thg2k
Copy link
Contributor Author

thg2k commented Dec 30, 2014

ok, sorry but I'm not paid for that, if I can fix something in the code (i already added a commit to fix travis complains) i'm happy to do so, but no wasting time. I hope you realize how broken your spinner implementation is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants