Skip to content

Conversation

@Enideo
Copy link

@Enideo Enideo commented Sep 15, 2010

Fixed the following bugs / requests:

However, the file size has doubled (extra 10kB when minified)!
Still, consider the following points:

  • includes all X11 HTML names (previously only 44, now 147),
  • rainbow animations easily possible through auto HSL conversion (forward and backwards),
  • $.support extended to detect rgba, hsl and hsla color string support,
  • rgba is automatically used if supported (progressive enhancement),
  • access to the new $.colors utility, useful for many ui developers
  • Plus, as $.colors has a modular design, we could remove some parts of it to reduce file size.

PS new to github: first pull request for jquery ui!

…rs. Fixed #4372 & #4635 (animate to transparent), #3806 (expose getRGB and getColor), #5215 (add support for rgba), #5393 (getColor reports inaccurate color for transparent elements in Webkit) as well as other enhancements (see pull request)
@scottgonzalez
Copy link
Member

Thanks Enideo. Could you split this into several smaller commits so it's easier to review? Also, you might want to fork http://github.com/jquery/jquery-color and send pull requests there as that's the official home for this code, we just pull it into jQuery UI.

@Enideo
Copy link
Author

Enideo commented Sep 27, 2010

Ok I'll try to break it down sometime but a little too busy at the moment.
I considered forking the original jquery-color but what i created grew beyond simple color animation so I felt it had become a different, independent project.
You could check my site to get a quick idea of this new project I've started, it's basically an extendible version of what John did, to reuse max code and allow developers to eliminate what they dont need:
http://enideo.com/#jquery-colors

When I've time I'll try to go over the points for my jquery-ui changes

@mgenereu
Copy link

mgenereu commented Feb 5, 2011

I love this pull request and the associated independent jQuery extension. I needed it to fix jQuery's results when querying the DOM for a color. IE just returns it back exactly as typed in the stylesheet instead of some consistent color object/array. Scott, what would your recommendation be for this library? Even thought jQuery-color and jQueryUI have these services internally (unexposed), do you think it would be useful to have jQuery's css() function to leverage it for true color abstraction? Also, if in jQuery, the jQueryUI and color plugin could just use that directly.

@scottgonzalez
Copy link
Member

I'm not sure how .css() would be involved. What did you have in mind?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants