- Notifications
You must be signed in to change notification settings - Fork 433
docs: Add Capacitor 8 upgrade guide and information #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| The latest updates on your projects. Learn more about Vercel for GitHub.
|
| Capacitor CLI now creates iOS SPM projects as default. | ||
| While it doesn't affect existing apps, if you remove the `ios` folder and run `npx cap add ios` again, it will be created using the SPM template, if you want to use the CocoaPods template, run `npx cap add ios --packagemanager CocoaPods` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is not related to the breaking change, wonder if we should link to the guide to migrate apps to SPM here, since it is now the default, and recommended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they remove the ios folder and run npx cap add ios (without --packagemanager CocoaPods) then they don't need to migrate, they will be migrated automatically, so I don't think we need to link the guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but if they have specific configurations on their iOS app (like specific properties on Info.plist), those would be removed.
Could be picked up by source control (if the project is in source control), but removing ios folder and re-adding it feels error prone no?
| | ||
| ## Breaking changes in Capacitor config file | ||
| | ||
| `appendUserAgent` had a bug on iOS that appended two whitespaces before appending the user agent and has been fixed. If you want to prevent the user agent change, add an extra whitespace on `ios.appendUserAgent`. Don't do it on the root `appendUserAgent` as it will also add the whitespace on Android. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these just spaces, or other whitespace characters. We should probably say which. I think just regular old spaces, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a space or whitespace, the one that appears when you press the long bar on your keyboard, like this
markemer left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a nitpick, I think we're ok. We can probably add the android breaking plugin changes later. (As in later today or tomorrow)
No description provided.