Skip to content

Conversation

@0xR
Copy link

@0xR 0xR commented Jul 16, 2022

Note github action are enabled for this fork and the tests should be green

  • improved the cleanup so no state is left when a query is removed from react-query
  • fixed a race condition where data was retrieved from cache before the cache was filled from firebase
  • Fixed the auth subscription key which was not unique which means that a resubscription didn't occur. A test checked this happened if the queryKey of useAuthUser changed, it should result in a new subscription.
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev-release@ddc98d0). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 978f125 differs from pull request most recent head 200ba06. Consider uploading reports for the commit 200ba06 to get more accurate results

@@ Coverage Diff @@ ## dev-release #54 +/- ## ============================================== Coverage ? 61.29% ============================================== Files ? 22 Lines ? 509 Branches ? 72 ============================================== Hits ? 312 Misses ? 197 Partials ? 0 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc98d0...200ba06. Read the comment docs.

 - @react-query-firebase/analytics@0.1.2-alpha.0 - @react-query-firebase/auth@1.0.0-dev.2 - @react-query-firebase/database@1.0.0-dev.2 - @react-query-firebase/firestore@1.0.0-dev.7 - @react-query-firebase/functions@1.0.0-dev.1
@cabljac cabljac merged commit 45b562b into invertase:dev-release Jul 20, 2022
@0xR
Copy link
Author

0xR commented Jul 21, 2022

@cabljac could you cut a dev release with this code merged? Maybe even make it a proper minor release since the current latest had various issues that are now solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants