Add useSignInWithCredentialMutation #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-query-firebase~114 Documentation is deployed and generated using docs.page. |
HassanBahati commented Oct 8, 2024
| "@vitest/coverage-istanbul": "^2.0.5", | ||
| "firebase": "^10.13.1", | ||
| "happy-dom": "^15.7.3", | ||
| "jsonwebtoken": "^9.0.2", |
Member Author
There was a problem hiding this comment.
introduced jsonwebtoken because while trying to generate an id token thats required by GoogleAuthProvider.credential ,other formats were being rejected with the error below
Ehesp reviewed Oct 10, 2024
| expect(error.code).toBe(expectedCode); | ||
| } else { | ||
| throw new Error( | ||
| "Expected a Firebase error, but received a different type." |
Member
There was a problem hiding this comment.
Probably worth logging the error here too otherwise it'll be tricky to debug in CI
Member Author
There was a problem hiding this comment.
i've enhanced this with logging as well.
…in expectFirebaseError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
this PR adds useSignInWithCredentialMutation hook