Add useGetCountFromServerQuery hook #105
Conversation
| To view this pull requests documentation preview, visit the following URL: react-query-firebase.invertase.dev/~105 Documentation is deployed and generated using docs.page. |
| ...options, | ||
| queryFn: async () => { | ||
| const snapshot = await getCountFromServer(query); | ||
| return snapshot?.data().count; |
There was a problem hiding this comment.
Any idea why would the snapshot here ever be nullish? From the API docs it should always return a snapshot: https://firebase.google.com/docs/reference/js/firestore_.md#getcountfromserver_4e56953
There was a problem hiding this comment.
true, ive actually removed the optional chaining
| ...options, | ||
| queryFn: async () => { | ||
| const snapshot = await getCountFromServer(query); | ||
| return snapshot.data().count; |
There was a problem hiding this comment.
Should we be returning the snapshot here or the count?
There was a problem hiding this comment.
should be returning the snapshot.
ive refactored to return an AggregateQuerySnapshot which is described as the return type of the getCountFromServer
| | ||
| await waitFor(() => expect(result.current.isSuccess).toBe(true)); | ||
| | ||
| expect(result.current.data?.data().count).toBe(3); |
There was a problem hiding this comment.
there is optional chaining at data?.data() because useQuery initializes with undefined data before the query resolves
There was a problem hiding this comment.
That's OK, it's because typescript isn't inferring isSuccess with data (since it's inside of waitFor).
…GetCountFromServerQuery
2 participants
This PR adds
useGetCountFromServerQueryhook