Skip to content

Commit fb83654

Browse files
maneeshtEhespHassanBahati
authored
feat(angular): Add Tanstack Angular Support (#166)
* Fixed autocomplete * Added tsup configuration * Added tsconfig.json * WIP * First pass at angular query * Fixed auto-reload queries * second run-through of tanstack query * Added comments * Added tracking to fdc * Removed angular changes * Upped the required version of firebase * updated to use 11.3.0 * Used correct enums * reverted prelude changes * Removed only * completed first pass * First pass at angular framework * Fixed typings * Added tracking * Fixed testing workflow * Fixed more tests * Addressed comments * Fixed react tests * Added firebase files * Added custom injector * Moved firebase files outside of individual folders * Wrote script to copy package.json * Added missing file * Brought back dataconnect-sdk in workspace * removed unnecessary js files * Updated to use workspaces * Fix wrong reporting * Fix runner * Fix reading of logs * Fix angular test * Miscellaneous cleanup * Fixed lockfile * chore: Linting fixes * chore: Update release flow * chore: Build flow * Moved dataconnect to dev deps * Updated lock file * Updated package.json to include build scripts * Update packages/angular/package.json Co-authored-by: Hassan Bahati <mukisabahati@gmail.com> * chore: Simplify build flow * Revert "chore: Simplify build flow" This reverts commit c348aa4. * Fixed generation and updated README * Removed peer dependency on firebase * Updated lockfile * Removed copyToBuild file * Added error log * Addressed comments * Updated biome formatting * Moved tanstack to peer dependency --------- Co-authored-by: Elliot Hesp <elliot.hesp@gmail.com> Co-authored-by: Hassan Bahati <mukisabahati@gmail.com>
1 parent df6b9a7 commit fb83654

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+4492
-3988
lines changed

.github/workflows/tests.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,16 @@ jobs:
5050
filters: |
5151
react:
5252
- 'packages/react/**'
53+
angular:
54+
- 'packages/angular/**'
5355
5456
# Run tests for the React package if it has changed
5557
- name: Run React Tests
5658
if: steps.changes.outputs.react == 'true'
57-
run: pnpm vitest --dom 'packages/react'
59+
run: cd packages/react && pnpm vitest --dom
60+
- name: Run Angular Tests
61+
if: steps.changes.outputs.angular == 'true'
62+
run: cd packages/angular && pnpm vitest --dom
5863

5964
# Run tests for the Vue package if it has changed
6065
# - name: Run Vue Tests

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ ui-debug.log
77
dist
88
*.log
99
.idea
10+
dataconnect/.dataconnect
1011

1112
functions/lib/**/*.js
1213
functions/lib/**/*.js.map

.vscode/launch.json

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
{
2+
// Use IntelliSense to learn about possible attributes.
3+
// Hover to view descriptions of existing attributes.
4+
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
5+
"version": "0.2.0",
6+
"configurations": [
7+
{
8+
"type": "node",
9+
"name": "vscode-jest-tests.v2",
10+
"request": "launch",
11+
"runtimeExecutable": "yarn",
12+
"args": [
13+
"test",
14+
"--watch-all=false",
15+
"--test-name-pattern",
16+
"${jest.testNamePattern}",
17+
"--test-path-pattern",
18+
"${jest.testFilePattern}"
19+
],
20+
"cwd": "${workspaceFolder}/packages/angular",
21+
"console": "integratedTerminal",
22+
"internalConsoleOptions": "neverOpen",
23+
"disableOptimisticBPs": true
24+
}
25+
26+
]
27+
}

.vscode/settings.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"angular.enable-strict-mode-prompt": false
3+
}

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The status of the following Firebase services and frameworks are as follows:
5959
| app-check | | | | | |
6060
| auth | 🟠 | | | | |
6161
| database | | | | | |
62-
| data-connect || | | | |
62+
| data-connect || | | | |
6363
| firestore | 🟠 | | | | |
6464
| firestore/lite | | | | | |
6565
| functions | | | | | |

biome.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@
2424
"noNonNullAssertion": "off"
2525
},
2626
"suspicious": {
27-
"noExplicitAny": "off"
27+
"noExplicitAny": "off",
28+
"noConfusingVoidType": "off"
2829
},
2930
"complexity": {
3031
"noForEach": "off"

0 commit comments

Comments
 (0)