Update client.ts #129
Open
Update client.ts #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
For some reason, type inference on this file fails during build step. Which means that if this code is put in a monorepo and becomes part of a package, the .d.ts file doesn't get generated, and when trpc is imported, the whole type inference gets lost. This little (mostly) documentation fix will ensure that people who come to tRPC-sveltekit, and copy code from the docs, will never encounter this issue.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For some reason, type inference on this file fails during build step. Which means that if this code is put in a monorepo and becomes part of a package, the
client.d.tsfile doesn't get generated, and whentrpcis imported, the whole type inference gets lost.This little (mostly) documentation fix will ensure that people who come to tRPC-sveltekit, and copy code from the docs, will never encounter this issue.