- Notifications
You must be signed in to change notification settings - Fork 319
fix: long timeranges for task queries truncated #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: bf97eea The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR ReviewOverall Assessment: Good fix for preventing ClickHouse query timeouts Code Quality Issues:
Positive Notes:
Recommendation: Address the logging accuracy issue before merge to avoid confusion during debugging. |
E2E Test Results✅ All tests passed • 25 passed • 3 skipped • 225s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 with one minor nitpick
@claude remove the unused variable that the reviewer Dan mentioned |
Code Review✅ No critical issues found. The implementation looks solid:
Minor observations (non-blocking):
|
Co-authored-by: Aaron Knudtson <knudtty@users.noreply.github.com>
Fixes HDX-2618
Related to https://github.com/ClickHouse/support-escalation/issues/6113