Synchronize FileLock with base from GHC 8.10 #231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| apveyor fails for a reason. So does travis on GHC-8.2 and older |
phadej reviewed Oct 21, 2019
Contributor
phadej left a comment
phadej left a comment There was a problem hiding this comment.
unknown flag in {-# OPTIONS_GHC #-} pragma: defined(aix_HOST_OS) is probably related to the code (old) hsc2hs generates?
| {-# LANGUAGE CPP #-} | ||
| {-# LANGUAGE InterruptibleFFI #-} | ||
| {-# LANGUAGE DeriveDataTypeable #-} | ||
| {-# LANGUAGE LambdaCase #-} |
Contributor
There was a problem hiding this comment.
LambdaCase and MultiWayIf are only GHC-7.6+, we test for GHC-7.4
I'd rather not use these, the patch would be less controversial then.
Closed
Contributor Author
| @phadej I folded your fixes into the branch and added a few of my own. |
This will ensure that the lock is promptly released on Windows.
Member
| This has been subsumed by #235 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #228.