Report missing .meta keys as SchemaErrors #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This change was triggered by trying make the codebase MonadFail compatible which exposed a `lookupM` convenience wrapper which reported lookup failures via Monad(fail). However, schema errors such as missing keys or similar are supposed to be reported via the `ReportSchemaError(expected)` mechanism. This however prompts a major version increment to 0.6.0.0. So this fixes two issues with one commit.
gbaz approved these changes Aug 26, 2019
23Skidoo reviewed Aug 27, 2019
| snapshotInfoRoot <- FileMap.lookupM snapshotMeta (pathRoot repoLayout) | ||
| snapshotInfoMirrors <- FileMap.lookupM snapshotMeta (pathMirrors repoLayout) | ||
| snapshotInfoTarGz <- FileMap.lookupM snapshotMeta (pathIndexTarGz repoLayout) | ||
| let lookupMeta k = case FileMap.lookup k snapshotMeta of |
Member
There was a problem hiding this comment.
Why not put lookupMeta in TUF.FileMap?
Member Author
There was a problem hiding this comment.
I mostly wanted to avoid increasing the exported API surface with a trivial definition; after all, having something like lookupM exposed was what had been causing this headache in the first place...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change was triggered by trying make the codebase MonadFail
compatible which exposed a
lookupMconvenience wrapper whichreported lookup failures via Monad(fail). However, schema errors
such as missing keys or similar are supposed to be reported via
the
ReportSchemaError(expected)mechanism.This however prompts a major version increment to 0.6.0.0.
So this fixes two issues with one commit.