feat(components): remove ember-get-config #3277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for GitHub.
|
zamoore force-pushed the main-5.0.0 branch 6 times, most recently from 686303f to 4b846d1 Compare zamoore force-pushed the feat/ember-get-config branch from bddfb59 to 4ba8a23 Compare 
Contributor
📦 RC Packages PublishedLatest commit: 15a171f Published 3 packages@hashicorp/design-system-codemods@0.5.2-rc-20251104031921@hashicorp/design-system-components@5.0.0-rc-20251104031921@hashicorp/flight-icons@4.0.0-rc-20251104031921 |
aklkv force-pushed the feat/ember-get-config branch from 4ba8a23 to a5aa2b7 Compare aklkv force-pushed the feat/ember-get-config branch from a5aa2b7 to bc6406f Compare 
zamoore reviewed Oct 27, 2025
| // the intersection observer makes loading unreliable in tests | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access | ||
| if (config.environment === 'test') { | ||
| if (macroCondition(isTesting())) { |
Contributor
There was a problem hiding this comment.
Could you explain a bit how this works?
Collaborator Author
There was a problem hiding this comment.
that part essentially would remove this code at build time if environment is anything but test this pattern should be used when there is no way to get config from the host app or you want to be removing part of code at the build time
aklkv force-pushed the feat/ember-get-config branch from c1fc806 to a613281 Compare aklkv force-pushed the feat/ember-get-config branch from a613281 to 5e70b59 Compare zamoore force-pushed the main-5.0.0 branch 2 times, most recently from c3e1df1 to 06d5696 Compare zamoore force-pushed the feat/ember-get-config branch from 5e70b59 to f42e5cd Compare 
Co-authored-by: jorytindall <2200899+jorytindall@users.noreply.github.com> Co-authored-by: Jory Tindall <jory.tindall@hashicorp.com>
aklkv force-pushed the feat/ember-get-config branch from b290d09 to 15a171f Compare zamoore approved these changes Nov 4, 2025
zamoore pushed a commit that referenced this pull request Nov 4, 2025
zamoore pushed a commit that referenced this pull request Nov 5, 2025
aklkv added a commit that referenced this pull request Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
📌 Summary
ember-get-configis problematic in vite world and doesn't work without a hack this hack will not be release and it is advised to move toappInstancelookupThis just does that for components and website (which was pretty strange usecase)
ember-unique-id-helper-polyfillsupport for this feature in includedember-source>v4.4- let me know if you want me to split it out🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.