Fix enable_async for aiohttp and sanic #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
r-owen changed the title 
Apply the fix suggested by ketanbshah in #64
Contributor Author
| The tests all pass for me on my computer. |
…aphql-server into fix_aiohttp_enable_async
KingDarBoja approved these changes Oct 17, 2020
Contributor
KingDarBoja left a comment
KingDarBoja left a comment There was a problem hiding this comment.
Thank for your contribution, I added extra tests for checking out this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #64 using the fix suggested by ketanbshah.
I admit that I am not positive the fix is required for sanic, but it should not hurt, and the original code was identical.