Enhance verify_lazy.js to validate API lazy-loading via getters, Add … #3857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…getter-based checks and multi-API validation to verify_lazy.js , Strengthen lazy-loading verification logic in verify_lazy.js
Author
| as soon as check the my contribution and notify me |
feywind added the do not merge Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR enhances the verify_lazy.js script to provide stronger validation of API lazy-loading behavior in the google-api-nodejs-client.
The existing script performed basic access checks but did not verify whether APIs were exposed via JavaScript getters, which is a key indicator of lazy loading. This change improves diagnostic accuracy by explicitly inspecting property descriptors and validating runtime behavior for commonly used APIs.
Changes Made
Added checks using Object.getOwnPropertyDescriptor to verify APIs are implemented as getters
Improved logging for clearer verification output
Added runtime validation for commonly used APIs (drive, gmail, youtube)
Refactored code for better readability and maintainability
Notes for Reviewers
This script depends on compiled output (build/src); please run npm run compile before execution
No runtime or production code paths were modified
Changes are limited to internal verification tooling
Impact
Improves confidence in the library’s lazy-loading architecture and strengthens internal verification without introducing breaking changes.