Skip to content

Updated dependencies #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updated dependencies #2334

wants to merge 3 commits into from

Conversation

margarita2104
Copy link

If you're updating existing documentation to its latest version, please ensure that you have:

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good
@margarita2104 margarita2104 requested a review from a team as a code owner October 1, 2024 18:27
@margarita2104 margarita2104 changed the title Margarita2104 Updated dependencies Oct 1, 2024
simon04
simon04 requested changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, simply updating the versions/releases is easy. Running the scrapers, adapting to documentation changes, fixing the scrapers, verifying that everything is fine is where the effort lies.

You stated " Tested the changes locally to ensure: The scraper still works without errors" – however the angular scraper immediately fails:

> bundle exec thor docs:generate --force --package angular bundler: failed to load command: thor (/Users/simon/src/devdocs/vendor/bundle/ruby/3.3.0/bin/thor) /Users/simon/src/devdocs/vendor/bundle/ruby/3.3.0/gems/yajl-ruby-1.4.3/lib/yajl/json_gem/parsing.rb:15:in `rescue in parse': lexical error: invalid char in json text. (JSON::ParserError) <!DOCTYPE html><!-- We set all (right here) ------^ from /Users/simon/src/devdocs/vendor/bundle/ruby/3.3.0/gems/yajl-ruby-1.4.3/lib/yajl/json_gem/parsing.rb:11:in `parse' from /Users/simon/src/devdocs/lib/docs/scrapers/angular.rb:39:in `block in initial_urls' ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@margarita2104 @simon04