CMake: corrections and updates #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
scivision force-pushed the update_cmake branch 2 times, most recently from ce8e22f to 2e31ccf Compare 
ivan-pi reviewed Jul 21, 2021
ivan-pi approved these changes Jul 21, 2021
Member
ivan-pi left a comment
ivan-pi left a comment There was a problem hiding this comment.
I left a comment, but otherwise +1 to merge.
Member
| All questions seem to be answered. I'll merge it. Thank you @scivision for this PR. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I helped implement CMake for stdlib, and some syntax and techniques have become obsolete or no longer relevant. At the time I implemented, quite old compilers were being considered, which have long since not been supported by stdlib.