Rename CMake project from stdlib to fortran_stdlib #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
milancurcic approved these changes Jan 7, 2021
jvdp1 approved these changes Jan 9, 2021
- match project name with name of produced library target - allows convenient reusing of the PROJECT_NAME variable in CMake and configure_file commands - might reduce risk for typos (PROJECT_NAME is highlighted, fortran_stdlib not)
awvwgk force-pushed the fortran_stdlib branch from f38f399 to e46df0a Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Part 2/3 for #287, status: optional. If you do not like this approach we can do #287 without it.
Changes:
stdlibtofortran_stdlibPROJECT_NAMECMake variable instead of usingfortran_stdlibdirectlyReasoning:
fortran_stdlibseems less likely to clash with something compared tostdlib)PROJECT_NAMEto write reusable/transferable CMake code for different projects (interesting for fpm generated CMake files as well)PROJECT_NAMEis accessible inconfigure_fileand can be used to create more general template files