draft for joss paper on sparse matrices #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jvdp1 approved these changes Sep 25, 2025
Member
jvdp1 left a comment
jvdp1 left a comment There was a problem hiding this comment.
I am not familiar with this format. Overall LGTM. I just have a few suggestions.
Comment on lines +110 to +111
| call dense2coo( A , COO ) | ||
| call coo2csr( COO , CSR ) |
Member
There was a problem hiding this comment.
Maybe for a new feature: call dense2csr(A, CSR)?
Contributor Author
There was a problem hiding this comment.
Yes, it could embed the call in just one. Actually I think it might be interesting to have a single interface to automatically detect the input and output matrices such as to internally apply the conversions having a unified API. Haven't thought it through yet though.
Member
There was a problem hiding this comment.
It could be something like:
subroutine dense2sparse_${s1}$(dense,sparse) ${t1}$, intent(in) :: dense(:,:) class(base_${s1}$_type), intent(out) :: sparse select type (sparse) type is (COO_${s1}$_type) type is (...) end subroutine
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Contributor Author
| I'll merge this on the separate branch to then start the review process with JOSS |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Opening stand-alone branch to manage joss paper