Skip to content

allow to change UA uri in runtime #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2024
Merged

allow to change UA uri in runtime #425

merged 2 commits into from
Aug 24, 2024

Conversation

@furmur
Copy link
Contributor

@furmur furmur commented Feb 7, 2024

  • allows to change uri configuration parameter for UA without instance reload
  • allows to set UA dynamic parameters from SIPUAHelper

useful to set From header display name and URI parts before the call.
example:

sip_ua_helper = SIPUAHelper(); ... sip_ua_helper.setUAParam('display_name','test'); sip_ua_helper.setUAParam('uri', URI('sip','42','domain.invalid')); sip_ua_helper.call(target);
cloudwebrtc
cloudwebrtc approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
@cloudwebrtc cloudwebrtc merged commit b0525de into flutter-webrtc:main Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@furmur @cloudwebrtc