Skip to content

Expose sendInfo from RTCSession to Call.sendInfo #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2021
Merged

Expose sendInfo from RTCSession to Call.sendInfo #227

merged 1 commit into from
Sep 16, 2021

Conversation

@makstheimba
Copy link

@makstheimba makstheimba commented Sep 16, 2021

Fix for #185
@cloudwebrtc
Copy link
Member

cloudwebrtc commented Sep 16, 2021

Cool, Maybe we should move InfoEvent from internal events to the public?
https://github.com/flutter-webrtc/dart-sip-ua/blob/master/lib/src/event_manager/internal_events.dart#L74

like info_events.dart and provide InfoEvent listener where.
https://github.com/flutter-webrtc/dart-sip-ua/blob/master/lib/src/sip_ua_helper.dart#L182
@makstheimba
Copy link
Author

makstheimba commented Sep 16, 2021 •
edited
Loading

@cloudwebrtc Do I understand correctly that in your comment you propose to add an ability to also listening for InfoEvents?

It may be a good suggestion. We didn't need it in our project and because of that I didn't thought about adding it 🤔
@cloudwebrtc
Copy link
Member

cloudwebrtc commented Sep 16, 2021

Okay，When someone needs this feature, I will create a new PR.
@cloudwebrtc cloudwebrtc merged commit 9f37077 into flutter-webrtc:master Sep 16, 2021
@sanekyy sanekyy mentioned this pull request Jul 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@makstheimba @cloudwebrtc