Expose existing functionality via UaSettings() for RFC8599 usage #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…act params and extra headers to be set for SIP REGISTER. Current use case for RFC8599 Push Notifcation support to pass Firebase Cloud Messaging Tokens and APNs Tokens in SIP registrations.
cloudwebrtc reviewed Aug 4, 2020
| /// Allow extra headers and Contact Params to be sent on REGISTER | ||
| /// Mainly used for RFC8599 Support | ||
| /// https://github.com/cloudwebrtc/dart-sip-ua/issues/89 | ||
| Map<String, dynamic> extraHeaders = {}; |
Member
There was a problem hiding this comment.
If the Settings.register_extera_headers type is List<String>, here the extraHeaders type should also be List<String>
Collaborator Author
There was a problem hiding this comment.
Yeah, spotted that after. Reason to be a list?
Collaborator Author
| Closing this. Not needed. Done in another PR. |
cloudwebrtc deleted the expose_registration_extraheaders_extraparams_in_settings branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Allow Contact params and extra headers to be set for SIP REGISTER. Current use case for RFC8599 Push Notification support to pass Firebase Cloud Messaging Tokens and APNs Tokens in SIP registrations. Refs #89