Skip to content

Conversation

xdongyan
Copy link
Contributor

@xdongyan xdongyan commented Aug 9, 2017

No description provided.

Copy link
Owner

@fishercoder1534 fishercoder1534 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open separate PR for these two commits.

System.out.println("Test2");
assertEquals("1(2()(4))(3)", test.tree2str(t));
}
@Test
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a blank line between tests please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, each time when I PR for a file and I need to close it for the second file that I want to PR?

assertEquals("1(2()(4))(3)", test.tree2str(t));
}
@Test
public void test3(){
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a space between () and {, or you could always select all and format all before you submit a PR.

a[a.length-1] = first;
return a;
}
//**credit : https://discuss.leetcode.com/topic/58459/java-o-n-solution-with-explanation
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave a blank line in between different functions.

@xdongyan xdongyan closed this Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants