Skip to content

Eason #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Eason #5

wants to merge 8 commits into from

Conversation

xdongyan
Copy link
Contributor

@xdongyan xdongyan commented Aug 8, 2017

No description provided.

fishercoder1534
fishercoder1534 reviewed Aug 8, 2017
View reviewed changes
Copy link
Owner

@fishercoder1534 fishercoder1534 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either squash all of your 8 commits into 1 or just create a new branch and re-push.
src/main/java/com/fishercoder/solutions/_459.java
}
// the idea is that the length substring will be divisor of the length s, then find the
//sub string and append s.length/sub.length times to check if the string is equaled to the original string.
//credit:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you missing a link or something here?
@fishercoder1534
Copy link
Owner

Also, please create a corresponding unit test in test folder instead of adding in main function.
My plan is to migrate all main functions in each class to each junit class file.

Thanks.
@xdongyan xdongyan closed this Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@xdongyan @fishercoder1534