uses s3put, also es6ed. #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jgallen23 reviewed Nov 21, 2016
| if (query.x && query.y) { | ||
| options.position = [query.x, query.y]; | ||
| } | ||
| options.gravity = query.gravity; |
There was a problem hiding this comment.
you have query here, but it's not in joi above
jgallen23 reviewed Nov 21, 2016
lib/index.js Outdated
| | ||
| module.exports = function(plugin, options, next) { | ||
| | ||
| module.exports = (plugin, options, next) => { |
There was a problem hiding this comment.
can you run a check to make sure either key/secret or profile is set? as well as bucket?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.