FIX: sort strings in UTF-8 encoded byte order #14312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
milaGGL changed the title 
ehsannas approved these changes Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#no-changelog
Adding test cases for sorting strings when special characters are included.
Other SDKs requires fix:
Java: googleapis/java-firestore#1967
Node: googleapis/nodejs-firestore#2275
Android: firebase/firebase-android-sdk#6615
Web: firebase/firebase-js-sdk#8691