Skip to content

Disable Firestore Source Tests #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2021
Merged

Disable Firestore Source Tests #417

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78e65e1
Disable test that seems to time out on Android.
ehsannas May 6, 2021
003d706
Disable all Firestore Source Tests.
ehsannas May 7, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 40 additions & 27 deletions firestore/integration_test_internal/src/source_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,12 @@
namespace firebase {
namespace firestore {

// TODO(b/187448376): Temporarily disabling all tests as they seem to time out
// on Android.

using SourceTest = FirestoreIntegrationTest;

TEST_F(SourceTest, GetDocumentWhileOnlineWithDefaultGetOptions) {
TEST_F(SourceTest, DISABLED_GetDocumentWhileOnlineWithDefaultGetOptions) {
MapFieldValue initial_data = {{"key", FieldValue::String("value")}};
DocumentReference doc_ref = DocumentWithData(initial_data);

Expand All @@ -29,7 +32,7 @@ TEST_F(SourceTest, GetDocumentWhileOnlineWithDefaultGetOptions) {
EXPECT_EQ(initial_data, snapshot.GetData());
}

TEST_F(SourceTest, GetCollectionWhileOnlineWithDefaultGetOptions) {
TEST_F(SourceTest, DISABLED_GetCollectionWhileOnlineWithDefaultGetOptions) {
std::map<std::string, MapFieldValue> initial_docs = {
{"doc1", {{"key1", FieldValue::String("value1")}}},
{"doc2", {{"key2", FieldValue::String("value2")}}},
Expand All @@ -46,7 +49,7 @@ TEST_F(SourceTest, GetCollectionWhileOnlineWithDefaultGetOptions) {
EXPECT_EQ(initial_docs, QuerySnapshotToMap(snapshot));
}

TEST_F(SourceTest, GetDocumentWhileOfflineWithDefaultGetOptions) {
TEST_F(SourceTest, DISABLED_GetDocumentWhileOfflineWithDefaultGetOptions) {
MapFieldValue initial_data = {{"key", FieldValue::String("value")}};
DocumentReference doc_ref = DocumentWithData(initial_data);

Expand All @@ -63,7 +66,7 @@ TEST_F(SourceTest, GetDocumentWhileOfflineWithDefaultGetOptions) {
EXPECT_EQ(initial_data, snapshot.GetData());
}

TEST_F(SourceTest, GetCollectionWhileOfflineWithDefaultGetOptions) {
TEST_F(SourceTest, DISABLED_GetCollectionWhileOfflineWithDefaultGetOptions) {
std::map<std::string, MapFieldValue> initial_docs = {
{"doc1", {{"key1", FieldValue::String("value1")}}},
{"doc2", {{"key2", FieldValue::String("value2")}}},
Expand Down Expand Up @@ -97,7 +100,7 @@ TEST_F(SourceTest, GetCollectionWhileOfflineWithDefaultGetOptions) {
EXPECT_EQ(new_data, QuerySnapshotToMap(snapshot));
}

TEST_F(SourceTest, GetDocumentWhileOnlineWithSourceEqualToCache) {
TEST_F(SourceTest, DISABLED_GetDocumentWhileOnlineWithSourceEqualToCache) {
MapFieldValue initial_data = {{"key", FieldValue::String("value")}};
DocumentReference doc_ref = DocumentWithData(initial_data);

Expand All @@ -112,7 +115,7 @@ TEST_F(SourceTest, GetDocumentWhileOnlineWithSourceEqualToCache) {
EXPECT_EQ(initial_data, snapshot.GetData());
}

TEST_F(SourceTest, GetCollectionWhileOnlineWithSourceEqualToCache) {
TEST_F(SourceTest, DISABLED_GetCollectionWhileOnlineWithSourceEqualToCache) {
std::map<std::string, MapFieldValue> initial_docs = {
{"doc1", {{"key1", FieldValue::String("value1")}}},
{"doc2", {{"key2", FieldValue::String("value2")}}},
Expand All @@ -130,7 +133,7 @@ TEST_F(SourceTest, GetCollectionWhileOnlineWithSourceEqualToCache) {
EXPECT_EQ(initial_docs, QuerySnapshotToMap(snapshot));
}

TEST_F(SourceTest, GetDocumentWhileOfflineWithSourceEqualToCache) {
TEST_F(SourceTest, DISABLED_GetDocumentWhileOfflineWithSourceEqualToCache) {
MapFieldValue initial_data = {{"key", FieldValue::String("value")}};
DocumentReference doc_ref = DocumentWithData(initial_data);

Expand All @@ -146,7 +149,7 @@ TEST_F(SourceTest, GetDocumentWhileOfflineWithSourceEqualToCache) {
EXPECT_EQ(initial_data, snapshot.GetData());
}

TEST_F(SourceTest, GetCollectionWhileOfflineWithSourceEqualToCache) {
TEST_F(SourceTest, DISABLED_GetCollectionWhileOfflineWithSourceEqualToCache) {
std::map<std::string, MapFieldValue> initial_docs = {
{"doc1", {{"key1", FieldValue::String("value1")}}},
{"doc2", {{"key2", FieldValue::String("value2")}}},
Expand Down Expand Up @@ -180,7 +183,7 @@ TEST_F(SourceTest, GetCollectionWhileOfflineWithSourceEqualToCache) {
EXPECT_EQ(new_data, QuerySnapshotToMap(snapshot));
}

TEST_F(SourceTest, GetDocumentWhileOnlineWithSourceEqualToServer) {
TEST_F(SourceTest, DISABLED_GetDocumentWhileOnlineWithSourceEqualToServer) {
MapFieldValue initial_data = {{"key", FieldValue::String("value")}};
DocumentReference doc_ref = DocumentWithData(initial_data);

Expand All @@ -194,7 +197,7 @@ TEST_F(SourceTest, GetDocumentWhileOnlineWithSourceEqualToServer) {
EXPECT_EQ(initial_data, snapshot.GetData());
}

TEST_F(SourceTest, GetCollectionWhileOnlineWithSourceEqualToServer) {
TEST_F(SourceTest, DISABLED_GetCollectionWhileOnlineWithSourceEqualToServer) {
std::map<std::string, MapFieldValue> initial_docs = {
{"doc1", {{"key1", FieldValue::String("value1")}}},
{"doc2", {{"key2", FieldValue::String("value2")}}},
Expand All @@ -211,7 +214,7 @@ TEST_F(SourceTest, GetCollectionWhileOnlineWithSourceEqualToServer) {
EXPECT_EQ(initial_docs, QuerySnapshotToMap(snapshot));
}

TEST_F(SourceTest, GetDocumentWhileOfflineWithSourceEqualToServer) {
TEST_F(SourceTest, DISABLED_GetDocumentWhileOfflineWithSourceEqualToServer) {
MapFieldValue initial_data = {{"key", FieldValue::String("value")}};
DocumentReference doc_ref = DocumentWithData(initial_data);

Expand All @@ -224,7 +227,7 @@ TEST_F(SourceTest, GetDocumentWhileOfflineWithSourceEqualToServer) {
EXPECT_EQ(future.error(), Error::kErrorUnavailable);
}

TEST_F(SourceTest, GetCollectionWhileOfflineWithSourceEqualToServer) {
TEST_F(SourceTest, DISABLED_GetCollectionWhileOfflineWithSourceEqualToServer) {
std::map<std::string, MapFieldValue> initial_docs = {
{"doc1", {{"key1", FieldValue::String("value1")}}},
{"doc2", {{"key2", FieldValue::String("value2")}}},
Expand All @@ -240,7 +243,7 @@ TEST_F(SourceTest, GetCollectionWhileOfflineWithSourceEqualToServer) {
EXPECT_EQ(future.error(), Error::kErrorUnavailable);
}

TEST_F(SourceTest, GetDocumentWhileOfflineWithDifferentGetOptions) {
TEST_F(SourceTest, DISABLED_GetDocumentWhileOfflineWithDifferentGetOptions) {
MapFieldValue initial_data = {{"key", FieldValue::String("value")}};
DocumentReference doc_ref = DocumentWithData(initial_data);

Expand Down Expand Up @@ -285,7 +288,7 @@ TEST_F(SourceTest, GetDocumentWhileOfflineWithDifferentGetOptions) {
EXPECT_EQ(future.error(), Error::kErrorUnavailable);
}

TEST_F(SourceTest, GetCollectionWhileOfflineWithDifferentGetOptions) {
TEST_F(SourceTest, DISABLED_GetCollectionWhileOfflineWithDifferentGetOptions) {
std::map<std::string, MapFieldValue> initial_docs = {
{"doc1", {{"key1", FieldValue::String("value1")}}},
{"doc2", {{"key2", FieldValue::String("value2")}}},
Expand Down Expand Up @@ -347,7 +350,7 @@ TEST_F(SourceTest, GetCollectionWhileOfflineWithDifferentGetOptions) {
EXPECT_EQ(future.error(), Error::kErrorUnavailable);
}

TEST_F(SourceTest, GetNonExistingDocWhileOnlineWithDefaultGetOptions) {
TEST_F(SourceTest, DISABLED_GetNonExistingDocWhileOnlineWithDefaultGetOptions) {
DocumentReference doc_ref = Document();

Future<DocumentSnapshot> future = doc_ref.Get();
Expand All @@ -359,7 +362,8 @@ TEST_F(SourceTest, GetNonExistingDocWhileOnlineWithDefaultGetOptions) {
EXPECT_FALSE(snapshot.metadata().has_pending_writes());
}

TEST_F(SourceTest, GetNonExistingCollectionWhileOnlineWithDefaultGetOptions) {
TEST_F(SourceTest,
DISABLED_GetNonExistingCollectionWhileOnlineWithDefaultGetOptions) {
CollectionReference col_ref = Collection();

Future<QuerySnapshot> future = col_ref.Get();
Expand All @@ -372,7 +376,8 @@ TEST_F(SourceTest, GetNonExistingCollectionWhileOnlineWithDefaultGetOptions) {
EXPECT_FALSE(snapshot.metadata().has_pending_writes());
}

TEST_F(SourceTest, GetNonExistingDocWhileOfflineWithDefaultGetOptions) {
TEST_F(SourceTest,
DISABLED_GetNonExistingDocWhileOfflineWithDefaultGetOptions) {
DocumentReference doc_ref = Document();

DisableNetwork();
Expand Down Expand Up @@ -400,7 +405,8 @@ TEST_F(SourceTest, DISABLED_GetDeletedDocWhileOfflineWithDefaultGetOptions) {
EXPECT_FALSE(snapshot.metadata().has_pending_writes());
}

TEST_F(SourceTest, GetNonExistingCollectionWhileOfflineWithDefaultGetOptions) {
TEST_F(SourceTest,
DISABLED_GetNonExistingCollectionWhileOfflineWithDefaultGetOptions) {
CollectionReference col_ref = Collection();

DisableNetwork();
Expand All @@ -414,7 +420,8 @@ TEST_F(SourceTest, GetNonExistingCollectionWhileOfflineWithDefaultGetOptions) {
EXPECT_FALSE(snapshot.metadata().has_pending_writes());
}

TEST_F(SourceTest, GetNonExistingDocWhileOnlineWithSourceEqualToCache) {
TEST_F(SourceTest,
DISABLED_GetNonExistingDocWhileOnlineWithSourceEqualToCache) {
DocumentReference doc_ref = Document();

// Attempt to get doc. This will fail since there's nothing in cache.
Expand All @@ -424,7 +431,8 @@ TEST_F(SourceTest, GetNonExistingDocWhileOnlineWithSourceEqualToCache) {
EXPECT_EQ(future.error(), Error::kErrorUnavailable);
}

TEST_F(SourceTest, GetNonExistingCollectionWhileOnlineWithSourceEqualToCache) {
TEST_F(SourceTest,
DISABLED_GetNonExistingCollectionWhileOnlineWithSourceEqualToCache) {
CollectionReference col_ref = Collection();

Future<QuerySnapshot> future = col_ref.Get(Source::kCache);
Expand All @@ -437,7 +445,8 @@ TEST_F(SourceTest, GetNonExistingCollectionWhileOnlineWithSourceEqualToCache) {
EXPECT_FALSE(snapshot.metadata().has_pending_writes());
}

TEST_F(SourceTest, GetNonExistingDocWhileOfflineWithSourceEqualToCache) {
TEST_F(SourceTest,
DISABLED_GetNonExistingDocWhileOfflineWithSourceEqualToCache) {
DocumentReference doc_ref = Document();

DisableNetwork();
Expand All @@ -448,7 +457,7 @@ TEST_F(SourceTest, GetNonExistingDocWhileOfflineWithSourceEqualToCache) {
EXPECT_EQ(future.error(), Error::kErrorUnavailable);
}

TEST_F(SourceTest, GetDeletedDocWhileOfflineWithSourceEqualToCache) {
TEST_F(SourceTest, DISABLED_GetDeletedDocWhileOfflineWithSourceEqualToCache) {
DocumentReference doc_ref = Document();
Await(doc_ref.Delete());

Expand All @@ -463,7 +472,8 @@ TEST_F(SourceTest, GetDeletedDocWhileOfflineWithSourceEqualToCache) {
EXPECT_FALSE(snapshot.metadata().has_pending_writes());
}

TEST_F(SourceTest, GetNonExistingCollectionWhileOfflineWithSourceEqualToCache) {
TEST_F(SourceTest,
DISABLED_GetNonExistingCollectionWhileOfflineWithSourceEqualToCache) {
CollectionReference col_ref = Collection();

DisableNetwork();
Expand All @@ -477,7 +487,8 @@ TEST_F(SourceTest, GetNonExistingCollectionWhileOfflineWithSourceEqualToCache) {
EXPECT_FALSE(snapshot.metadata().has_pending_writes());
}

TEST_F(SourceTest, GetNonExistingDocWhileOnlineWithSourceEqualToServer) {
TEST_F(SourceTest,
DISABLED_GetNonExistingDocWhileOnlineWithSourceEqualToServer) {
DocumentReference doc_ref = Document();

Future<DocumentSnapshot> future = doc_ref.Get(Source::kServer);
Expand All @@ -489,7 +500,8 @@ TEST_F(SourceTest, GetNonExistingDocWhileOnlineWithSourceEqualToServer) {
EXPECT_FALSE(snapshot.metadata().has_pending_writes());
}

TEST_F(SourceTest, GetNonExistingCollectionWhileOnlineWithSourceEqualToServer) {
TEST_F(SourceTest,
DISABLED_GetNonExistingCollectionWhileOnlineWithSourceEqualToServer) {
CollectionReference col_ref = Collection();

Future<QuerySnapshot> future = col_ref.Get(Source::kServer);
Expand All @@ -502,7 +514,8 @@ TEST_F(SourceTest, GetNonExistingCollectionWhileOnlineWithSourceEqualToServer) {
EXPECT_FALSE(snapshot.metadata().has_pending_writes());
}

TEST_F(SourceTest, GetNonExistingDocWhileOfflineWithSourceEqualToServer) {
TEST_F(SourceTest,
DISABLED_GetNonExistingDocWhileOfflineWithSourceEqualToServer) {
DocumentReference doc_ref = Document();

DisableNetwork();
Expand All @@ -514,7 +527,7 @@ TEST_F(SourceTest, GetNonExistingDocWhileOfflineWithSourceEqualToServer) {
}

TEST_F(SourceTest,
GetNonExistingCollectionWhileOfflineWithSourceEqualToServer) {
DISABLED_GetNonExistingCollectionWhileOfflineWithSourceEqualToServer) {
CollectionReference col_ref = Collection();

DisableNetwork();
Expand Down