Skip to content

Create build matrices & test matrices for integration test workflow #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
May 10, 2021
Merged

Create build matrices & test matrices for integration test workflow #415

merged 53 commits into from
May 10, 2021

Conversation

sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented May 6, 2021 •
edited
Loading

  • Divided the matrix into build matrices & test matrices. Now we can test on different devices in parallel.
  • Summary log has two parts: build summary & test summary. Changed the summarize script accordingly.
  • Both testapps & logs are uploaded as artifacts. retention: 2 days.
  • Download iOS Simulator if the device doesn't exist.
  • Android Emulator test log is moved to Emulator's internal storage, because some Emulators don't have external storage.
  • Formatted the workflow
    • Step names always start with caps
    • Step names more descriptive
    • No new lines between steps
    • If it’s one short & sweet command, then put in the same line with run: cmd
    • If the command is too long, then break it down into multiply lines.
  • other small fixes.
sunmou99 and others added 30 commits April 30, 2021 04:22
@sunmou99
create mobile test flag & matrix
ce3a16e
@sunmou99
add FTL test
4996a3e
@sunmou99
divide build matrix into 3
cbf1674
@sunmou99
update dependency
8d0f568
@sunmou99
update platform variables
4a803bc
@sunmou99
set artifact retention to 1 day
852713d
@sunmou99
remove unsed conditional logic
f789626
@sunmou99
fail-fast: false
8edc6da
@sunmou99
remove unsed conditional logic
c9d4540
@sunmou99
update job needs
150fe97
@sunmou99
update job dependency
9f686bc
@sunmou99
update artifact names
a9be8f0
@sunmou99
fix bug when build for different platform
6161725
@sunmou99
add test desktop matrix
bef8f5f
@sunmou99
update job names
0e53981
@sunmou99
upload desktop artifact
652aa54
@sunmou99
fix syntax
a425fe5
@sunmou99
create desktop artifact
784576f
@sunmou99
google-services.json for desktop test
6473499
@sunmou99
update test devices
900f06d
@sunmou99
add build & test resutl artifacts
ffb371e
@sunmou99
desktop summary log
256f1fd
@sunmou99
summarize test results
c95de30
@sunmou99
change flag separator
3ac529d
@sunmou99
change log name
4e4a03d
@sunmou99
test new log summary
ab80724
@sunmou99
fix typo
8795884
@sunmou99
Merge branch 'main' into feature/mobile-test-martix
bec5ad6
@sunmou99
resolve merge conflict
e0b19af
@sunmou99
print summary log
656bd06
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels May 7, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 7, 2021
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label May 7, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 7, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 7, 2021
jonsimantov
jonsimantov previously approved these changes May 7, 2021
View reviewed changes
@jonsimantov jonsimantov self-requested a review May 7, 2021 20:18
@jonsimantov
Copy link
Contributor

jonsimantov commented May 7, 2021 •
edited
Loading

The changes look good, but what's with tests that are currently failing? Do we need to disable the virtual tests for now?

Also, in the summary, we should once again list whether each one is on a real or virtual device. Since for iOS I can't tell at a glance that iPhone-8 failures are on simulator.
@sunmou99 sunmou99 added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 7, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: failed This PR's integration tests failed. labels May 7, 2021
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label May 7, 2021
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label May 7, 2021
@github-actions
Copy link

github-actions bot commented May 7, 2021 •
edited
Loading

✅  Integration test succeeded!

Requested by @sunmou99 on commit 7c746b0
Last updated: Fri May 7 16:09:38 PDT 2021
View integration test results
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 7, 2021
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 7, 2021
@sunmou99 sunmou99 merged commit 6d5fbae into main May 10, 2021
@sunmou99 sunmou99 deleted the feature/mobile-test-martix branch May 10, 2021 17:22
chkuang-g pushed a commit that referenced this pull request May 12, 2021
@sunmou99 @chkuang-g
Create build matrices & test matrices for integration test workflow (#…
cb76f62 
…415)
@firebase firebase locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes tests: succeeded This PR's integration tests succeeded.

3 participants

@sunmou99 @jonsimantov @DellaBitta