Work on deflaking Storage integration test on mobile, particularly the large file download/pause/resume. #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
test is so flaky.
jonsimantov added the tests-requested: quick jonsimantov added tests-requested: quick 
github-actions bot added tests: in-progress 
firebase-workflow-trigger bot removed the tests: in-progress jonsimantov force-pushed the bugfix/deflake-storage-test branch from d5078f2 to 8efd4fa Compare jonsimantov added the tests-requested: quick github-actions bot added tests: in-progress jonsimantov added the tests-requested: quick github-actions bot added tests: failed firebase-workflow-trigger bot removed the tests: in-progress jonsimantov added the tests-requested: quick github-actions bot removed the tests-requested: quick firebase-workflow-trigger bot removed the tests: in-progress github-actions bot added tests: in-progress jonsimantov added the tests-requested: quick github-actions bot added tests: failed firebase-workflow-trigger bot removed the tests: in-progress jonsimantov added tests-requested: quick jonsimantov added tests-requested: quick 
DellaBitta approved these changes Apr 30, 2021
jonsimantov added tests-requested: quick github-actions bot added tests: in-progress 
✅ Integration test succeeded!Requested by @jonsimantov on commit 0750ba2 |
github-actions bot added the tests: succeeded firebase-workflow-trigger bot removed the tests: in-progress 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This test adds a convenience method RunFlakyBlock to firebase_test_framework that allows you to run a block multiple times, with exponential backoff until it succeeds (or fails a few times). This allows you to perform tests that have a chance of failure, such as uploading/downloading large files.